-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some issues in 2.2 #1565
Merged
ccx1024cc
merged 7 commits into
dragonflyoss:stable/v2.2
from
ccx1024cc:morgan/up2.2-fix
Mar 28, 2024
Merged
fix: some issues in 2.2 #1565
ccx1024cc
merged 7 commits into
dragonflyoss:stable/v2.2
from
ccx1024cc:morgan/up2.2-fix
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Case1: Fuse server exits in thread not main. There is possibility that process finishes before shutdown of server. 2. Case2: Fuse server exits in thread of state machine. There is possibiltiy that state machine not responses to signal catch thread. Then dead lock happens. Process exits before shutdown of server. This pr aims to seperator shutdown actions from signal catch handler. It only notifies controller. Controller exits with shutdown of fuse server. No race. No deadlock. Signed-off-by: 泰友 <[email protected]>
There are scenes that cache file is smaller than expect size. Such as: 1. Nydusd 1.6 generates cache file by prefetch, which is smaller than size in boot. 2. Nydusd 2.2 generates cache file by prefetch, when image not provide ext blob tables. 3. Nydusd not have enough time to fill cache for blob. Equality check for size is too much strict for both 1.6 compatibility and 2.2 concurrency. This pr ensures blob size smaller or equal than expect size. It also truncates blob cache when smaller than expect size. Signed-off-by: 泰友 <[email protected]>
ccx1024cc
requested review from
bergwolf,
imeoer and
power-more
and removed request for
a team
March 27, 2024 07:01
ccx1024cc
force-pushed
the
morgan/up2.2-fix
branch
from
March 27, 2024 07:43
5fb77f2
to
356ddaa
Compare
Nydus2.2 has same format for blob cache and bitmap on disk. However, 2.2 nydusd not use blob cache of 1.6 nydusd. This pr counts ready chunk number for both 1.6 and 2.2, instead of thinking it as not filled at all. Signed-off-by: 泰友 <[email protected]>
User io may involve discontinuous segments in different chunks. Bad read is produced by merging them into continuous one. That is what Region does. This pr separate discontinuous segments into different regions, avoiding merging forcibly. Signed-off-by: 泰友 <[email protected]>
ccx1024cc
force-pushed
the
morgan/up2.2-fix
branch
from
March 27, 2024 07:51
356ddaa
to
577f69a
Compare
Upgrade mio to 0.8.11 Upgrade h2 to 0.3.25 Signed-off-by: 泰友 <[email protected]>
ccx1024cc
force-pushed
the
morgan/up2.2-fix
branch
2 times, most recently
from
March 27, 2024 08:37
e9482d7
to
8fb1736
Compare
ccx1024cc
force-pushed
the
morgan/up2.2-fix
branch
2 times, most recently
from
March 27, 2024 09:07
2bdbee1
to
1a6eaed
Compare
Signed-off-by: 泰友 <[email protected]>
ccx1024cc
force-pushed
the
morgan/up2.2-fix
branch
from
March 27, 2024 09:19
1a6eaed
to
7182c36
Compare
imeoer
approved these changes
Mar 27, 2024
ccx1024cc
force-pushed
the
morgan/up2.2-fix
branch
4 times, most recently
from
March 27, 2024 11:19
331a804
to
8151f2b
Compare
From 1.66 to 1.70 Signed-off-by: 泰友 <[email protected]>
ccx1024cc
force-pushed
the
morgan/up2.2-fix
branch
from
March 27, 2024 11:26
8151f2b
to
3f76fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes